Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the rust-version from 1.56.0 to 1.75.0 #41

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

cverna
Copy link
Member

@cverna cverna commented Apr 17, 2024

No description provided.

@cverna cverna changed the title Update the rust-version from 1.56.0 to 1.75.0 Update the rust-version from 1.56.0 to 1.71.0 Apr 17, 2024
@cverna cverna added the skip-notes This PR does not need release notes label Apr 17, 2024
@travier
Copy link
Member

travier commented Apr 17, 2024

coreos-installer is currently using 1.70.0 so we should probably use that https://github.com/coreos/coreos-installer/blob/main/Cargo.toml#L6

@travier
Copy link
Member

travier commented Apr 17, 2024

Not sure where we use that / which version is in RHEL 9 now.

@HuijingHei
Copy link
Member

Maybe it is OK, check https://github.com/coreos/zincati/blob/main/Cargo.toml#L11 is using 1.71.0, but we do not have zincati in RHEL.

@cverna cverna changed the title Update the rust-version from 1.56.0 to 1.71.0 Update the rust-version from 1.56.0 to 1.70.0 Apr 17, 2024
@cverna
Copy link
Member Author

cverna commented Apr 17, 2024

Updated to 1.70.0.

Not sure where we use that / which version is in RHEL 9 now.

Same :-)

@travier
Copy link
Member

travier commented Apr 17, 2024

OK, Jonathan made coreos/coreos-installer#1453 so we can use that for all our repos.

@cverna cverna removed the skip-notes This PR does not need release notes label Apr 18, 2024
@cverna cverna changed the title Update the rust-version from 1.56.0 to 1.70.0 Update the rust-version from 1.56.0 to 1.75.0 Apr 18, 2024
@cverna
Copy link
Member Author

cverna commented Apr 18, 2024

Updated to match the change made in coreos/coreos-installer#1453

Copy link
Member

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cverna cverna merged commit 64e6fde into coreos:main Apr 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants