release: Merge brew job with release job #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ravanelli
commented
Jun 30, 2023
ravanelli
commented
- We decided to add brew into the release job, since make sense to upload the metadata to brew everytime we release something.
|
/hold We need it first https://github.com/coreos/coreos-assembler/pull/3519/files as the backports for it.
|
ravanelli
force-pushed
the
brew_release
branch
2 times, most recently
from
5d51d3a
to
da989d6
Compare
|
should we also be deleting upload-brew.Jenkinsfile ? |
ravanelli
force-pushed
the
brew_release
branch
3 times, most recently
from
23c0927
to
7281b48
Compare
dustymabe
reviewed
Jul 12, 2023
ravanelli
force-pushed
the
brew_release
branch
2 times, most recently
from
01c4d91
to
abfc89b
Compare
dustymabe
requested changes
Jul 17, 2023
dustymabe
reviewed
Jul 17, 2023
|
All the backport PRs are merged. We are ok to merge this PR now too. |
- We decided to add brew into the release job, since make sense to upload the metadata to brew everytime we release something; - Delete jobs/upload-brew.Jenkinsfile.
marmijo
reviewed
Jul 25, 2023
There was a problem hiding this comment.
When these jobs were merged, the RHCOS secrets are being passed in when creating the pod in all cases. This means that the secrets are being passed in when creating the pod in FCOS and causing the pods to fail. We'll need to determine how to differentiate between FCOS and RHCOS here.
https://github.com/coreos/fedora-coreos-pipeline/pull/886/files#diff-4768730b889afbd1361511a1e552ee9a9f29b11a7e578aa3ede5e57db08762acR91-R93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.