Prep patches for S3 & devel #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new stream parameter to choose which stream we're building on. Of course, this doesn't actually *change* anything yet, but it's a first step. Notably, we denote the current pipeline we have as the `testing` stream for now.
I opted for a config file here instead of environment variables, since the former is less likely to inadvertently leak somewhere. Prep for actually using it in the pipeline.
Prep for supporting devel pipelines, where the source config might come from different places in different runs.
dustymabe
reviewed
May 31, 2019
| rm -rf src/config | ||
|
|
||
| # in the future, the stream will dictate the branch in the prod path | ||
| coreos-assembler init --force https://github.com/coreos/fedora-coreos-config |
There was a problem hiding this comment.
I wonder if the URL should be templatized
There was a problem hiding this comment.
Yup, that's coming up in a next patch. :)
|
LGTM |
dustymabe
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are split out of #59 and should be straightforward to review. The first two have no impact on the current pipeline. The last one slightly modifies how initialization is performed.