Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: mark denylisted tests with 'warn: true' #2517

Closed

Conversation

nikita-dubrovskii
Copy link
Contributor

This patch adds behavior described here: coreos/coreos-assembler#3344

Requires: coreos/coreos-assembler#3539

@dustymabe
Copy link
Member

We don't want to make any modifications to the current denylist. If you're going off of what was described in coreos/coreos-assembler#3344 (comment) and coreos/coreos-assembler#3344 (comment) this isn't needed. i.e. when no warn: value exists we won't run the test (the current behavior). IMO we should close this PR.

After coreos/coreos-assembler#3539 merges (or any other PR that fulfills coreos/coreos-assembler#3344) we can then start to use it here in the config repo but really I would only use it for specific tests that we want the functionality for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants