Revert "Use dd conv=sparse"
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 33ba62e. As bgilbert points out in coreos#20 (comment) > This isn't safe. The image might contain zeroed blocks for reasons other > than unallocated space, and if the target disk already has data on it, > we'll write a corrupt image to disk.
Merged
|
Could you PR this to the |
It is done. |
bgilbert
approved these changes
Oct 29, 2019
glennswest
referenced
this pull request
in glennswest/coreos-installer
Mar 31, 2020
Revert "Use `dd conv=sparse`"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 33ba62e.
As bgilbert points out in
#20 (comment)