Create builds dir helpers and switch over to using them #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
force-pushed
the
pr/build-layout-prep2
branch
3 times, most recently
from
ec320f3
to
cbb0b5e
Compare
|
Rebased onto master! |
ajeddeloh
approved these changes
Jul 3, 2019
jlebon
force-pushed
the
pr/build-layout-prep2
branch
from
cbb0b5e
to
d6ba989
Compare
|
Rebased! |
|
Gonna merge this one soonish if there are no other comments. |
Prep for introducing a new `builds/` dir layout. This will allow us to adapt the whole codebase to a new layout at once by enhancing the `Builds` class. The next commit will switch over all the commands to use these helpers. I kept them separate for easier review.
Prep for switching those over to the new build layout. Most commands have pretty straightforward changes. Some of the more complex ones that deal with the build layout a lot were refactored a bit as prep for multi-arch.
jlebon
force-pushed
the
pr/build-layout-prep2
branch
from
d6ba989
to
dce2779
Compare
|
Rebased! ⬆️ |
|
Merging, thanks all for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the last two commits are new here. The rest are from #590.
The strategy here is to create a
Buildsclass and make use of it in all the commands instead of manually synthesizing paths to build dirs. Outside of cosa, one can still (and will continue to be able to) do this of course, though once the multi-arch layout comes into effect, it will require knowing which layout one is dealing with (which should be clear for e.g. pipeline code). For cosa itself, theBuildsclass will abstract over these differences, so all commands will keep on working regardless of the actual layout.Requires #590.