-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp: Support AMD SEV-SNP
confidential instances
#3871
Conversation
6bdeab5
to
d3dc5b4
Compare
hold on, seems need to rebase first |
d3dc5b4
to
f66d626
Compare
c46ddfb
to
e2cac4b
Compare
Ready to review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this code in-depth but that looks good to me
According to @jmarrero 's suggestion, build locally and run test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane overall. Let's fold the last commit into the first (which would now be the second)?
This was achieved via: ``` go get -u google.golang.org/[email protected] go get google.golang.org/api/[email protected] go get google.golang.org/api/[email protected] go get github.com/coreos/coreos-assembler/mantle/auth go get github.com/coreos/coreos-assembler/mantle/cmd/kola go get github.com/coreos/coreos-assembler/mantle/cmd/ore/gcloud go mod vendor ```
c16d522
to
0a88d9f
Compare
Update is done, thanks @jlebon for the review! For unsupported
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - minor suggestion in the code.
0a88d9f
to
934388f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
`sev_snp` Based on coreos/coreos-assembler#3871 (cherry picked from commit 0b797dd)
`sev_snp` Based on coreos/coreos-assembler#3871 (cherry picked from commit 0b797dd)
mantle: bump google.golang.org/api library to latest (0.196.0)
This was achieved via:
mantle: Support AMD SEV-SNP confidential instances on GCP
Fix #3556