Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s390x: add kargs embed area #3527

Merged
merged 1 commit into from
Jul 25, 2023
Merged

s390x: add kargs embed area #3527

merged 1 commit into from
Jul 25, 2023

Conversation

nikita-dubrovskii
Copy link
Contributor

@nikita-dubrovskii nikita-dubrovskii commented Jul 7, 2023 •
edited
Loading

With coreos/coreos-installer#1230 it allows to modify ISO kargs on s390x

@nikita-dubrovskii nikita-dubrovskii force-pushed the s390x_iso_kargs branch 4 times, most recently from 927a1a5 to d4a3049 Compare July 10, 2023 10:12
dustymabe
dustymabe reviewed Jul 12, 2023
View reviewed changes
src/cmd-buildextend-live Outdated Show resolved Hide resolved
dustymabe
dustymabe previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though I don't feel super qualified to review this code.

jschintag
jschintag previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@jschintag jschintag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert bgilbert mentioned this pull request Jul 13, 2023
Merged
dustymabe
dustymabe approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bgilbert
bgilbert approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikita-dubrovskii nikita-dubrovskii merged commit 698a1ea into coreos:main Jul 25, 2023
2 checks passed
@nikita-dubrovskii nikita-dubrovskii deleted the s390x_iso_kargs branch July 25, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschintag jschintag jschintag left review comments

@bgilbert bgilbert bgilbert approved these changes

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikita-dubrovskii @bgilbert @dustymabe @jschintag