Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift/v4.16: Stabilize 4.16.0 spec and add openshift 4.17-experimental spec #535

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

yasminvalim
Copy link
Contributor

@yasminvalim yasminvalim commented May 28, 2024

openshift/v4.16: Stabilize 4.16.0 spec

Stabilize on ignition 3.4, fcos 1.5 and base 0.5 specs


openshift/v4.16: Remove GRUB password support

Support is still missing in the MCO.

See: https://issues.redhat.com/browse/MCO-630


openshift/v4_17_exp: Add 4.17.0-experimental spec


Fixes: #533

@yasminvalim yasminvalim force-pushed the main-openshift-4.16-stable branch 4 times, most recently from 8e74e3b to 6f7f189 Compare May 29, 2024 14:21
@travier
Copy link
Member

travier commented May 29, 2024

https://github.com/coreos/butane/blob/main/internal/doc/butane.yaml#L352 > Those need to be updated to list 4.16.0 now as part of the GRUB removal change.

@travier
Copy link
Member

travier commented May 30, 2024

Found two more "typos" but there are other missing changes (GRUB password support should be there).

One way to make this easier when creating the new experimental version is to copy the files from before we stabilized the 4.16-exp version and then updating 16 to 17, as everything else will stay the same.

@yasminvalim yasminvalim force-pushed the main-openshift-4.16-stable branch 6 times, most recently from 2827001 to 74511d2 Compare May 31, 2024 18:19
@yasminvalim
Copy link
Contributor Author

https://github.com/coreos/butane/blob/main/internal/doc/butane.yaml#L352 > Those need to be updated to list 4.16.0 now as part of the GRUB removal change.

I updated it. Can you take a look? Thanks!

@yasminvalim
Copy link
Contributor Author

Found two more "typos" but there are other missing changes (GRUB password support should be there).

One way to make this easier when creating the new experimental version is to copy the files from before we stabilized the 4.16-exp version and then updating 16 to 17, as everything else will stay the same.

I re-did to avoid mistakes while doing the 4.17.0_exp. I think now is closer to the ideal. Can you take another look and see what is missing? Thanks!

@yasminvalim yasminvalim force-pushed the main-openshift-4.16-stable branch 3 times, most recently from 1dfc357 to 82ca2f1 Compare May 31, 2024 18:38
docs/upgrading-openshift.md Outdated Show resolved Hide resolved
@travier
Copy link
Member

travier commented Jun 3, 2024

I think this looks good. One change needed for the release notes and then I'll do a final check/review.

@yasminvalim yasminvalim force-pushed the main-openshift-4.16-stable branch 2 times, most recently from 57bfae7 to 8edce08 Compare June 3, 2024 14:04
@yasminvalim
Copy link
Contributor Author

I think this looks good. One change needed for the release notes and then I'll do a final check/review.

I changed docs/upgrading-openshift.md. Any other docs updated or are we good to go? Thanks!

@yasminvalim
Copy link
Contributor Author

I think this looks good. One change needed for the release notes and then I'll do a final check/review.

I think everything looks okay now. Feel free to review it again and tell me if there is anything I could improve!

Stabilize on ignition 3.4, fcos 1.5 and base 0.5 specs
@travier travier force-pushed the main-openshift-4.16-stable branch from 8edce08 to 0212c04 Compare June 5, 2024 13:48
@travier
Copy link
Member

travier commented Jun 5, 2024

Thanks, this looks complete. I did a minor re-split of the commits but changed nothing to what you did.

So LGTM.

@travier travier enabled auto-merge June 5, 2024 13:52
@travier travier merged commit 6967c6e into coreos:main Jun 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize openshift v4.16.0 spec
2 participants