Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize openshift 4.14.0; create openshift 4.15.0-experimental #491

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

travier
Copy link
Member

@travier travier commented Sep 14, 2023

See checklist in #488.


openshift/v4_15_exp: Copy from 4.14_exp


openshift/v4_15_exp: Update spec to 4.15.0-experimental


openshift/v4.14: Stabilize 4.14.0 spec


openshift/v4.14: Use fcos 1.5 & ignition 3.4 specs

Stabilise openshift 4.14.0 spec on fcos 1.5 and ignition 3.4 stable
specs. The MCO is now capable of understanding Ignition 3.4.0 specs and
uses that by default.

See: openshift/machine-config-operator#3576
See: openshift/machine-config-operator#3814


openshift/v4.14: Remove GRUB password support

Remove all GRUB bootloader configuration sugar for openshift/v4.14
configs as the MCO does not know how to manage files in the read only
/boot partition yet. While we could use Ignition to write the initial
file, any update would fail which makes for a bad user experience.

This is revert of [1] for openshift/v4.14 only.

[1] 4bd006e
See: https://issues.redhat.com/browse/OCPSTRAT-831
See: https://issues.redhat.com/browse/OCPSTRAT-113


NEWS: Update for 4.14 stabilization

Fixes: #488


References for this PR:

@travier travier changed the title WIP: Stabilize 4.14 spec WIP: Stabilize openshift 4.14.0; create openshift 4.15.0-experimental Sep 14, 2023
@travier travier force-pushed the stabilize-414 branch 2 times, most recently from 6dcb9f3 to 46376bd Compare September 14, 2023 14:26
@travier
Copy link
Member Author

travier commented Sep 18, 2023

Currently trying to figure out if the MCO supports swap in 4.14 or not.

@travier
Copy link
Member Author

travier commented Sep 18, 2023

We likely don't support setting up swap yet in openshift (see https://kubernetes.io/blog/2023/08/24/swap-linux-beta/) so maybe we should remove those mentions from the docs.

Copy link
Collaborator

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see, everything looks correct. My only nit is the commit message for removing the Grub password. It would be helpful to try and document why in the commit message.

@prestist
Copy link
Collaborator

We likely don't support setting up swap yet in openshift (see https://kubernetes.io/blog/2023/08/24/swap-linux-beta/) so maybe we should remove those mentions from the docs.

Hmm, thats a bit sticky. Once this is stabilized I suspect updates continue to flow into open shift 4.14.0?
If so then is there not the likelihood that it will support swap?

Stabilise openshift 4.14.0 spec on fcos 1.5 and ignition 3.4 stable
specs. The MCO is now capable of understanding Ignition 3.4.0 specs and
uses that by default.

See: openshift/machine-config-operator#3576
See: openshift/machine-config-operator#3814
Remove all GRUB bootloader configuration sugar for openshift/v4.14
configs as the MCO does not know how to manage files in the read only
/boot partition yet. While we could use Ignition to write the initial
file, any update would fail which makes for a bad user experience.

This is revert of [1] for openshift/v4.14 only.

[1] coreos@4bd006e
See: https://issues.redhat.com/browse/OCPSTRAT-831
See: https://issues.redhat.com/browse/OCPSTRAT-113
@travier travier marked this pull request as ready for review September 21, 2023 14:29
@travier
Copy link
Member Author

travier commented Sep 21, 2023

I've updated some docs elements and finalized the commit messages. This should be ready for a final review and then we can make a new release.

@travier travier changed the title WIP: Stabilize openshift 4.14.0; create openshift 4.15.0-experimental Stabilize openshift 4.14.0; create openshift 4.15.0-experimental Sep 22, 2023
Copy link
Collaborator

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for doing this :)

@travier travier merged commit 790ccc3 into coreos:main Oct 2, 2023
8 checks passed
@travier travier deleted the stabilize-414 branch October 2, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize OCP 4.14 spec
2 participants