bootupctl: Clear failure status from previous runs #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travier
force-pushed
the
main-systemctl-reset
branch
from
593c2aa
to
5775985
Compare
|
This does not check the return code of the Maybe we should also completely ignore stdout/stderr for this command. |
This also sounds like a good idea. |
cgwalters
approved these changes
Sep 2, 2024
If for whatever reason a bootupd command fails, it will leave the systemd service unit in a failed state and systemd will then refuse to run a unit under the same name with `systemd-run` again until the failure is cleared. Thus systematically call `systemctl reset-failed` before calling `systemd-run` to clear any potential failures from previous calls. Do not check the return code of the systemctl command on purpose as it may fail if the unit does not exists yet, i.e. if no bootupctl command has been run yet. Also ignore stdout/stderr to avoid showing unexpected errors messages to users. See: coreos#707 See: coreos#663
travier
force-pushed
the
main-systemctl-reset
branch
from
5775985
to
6fcc010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for whatever reason a bootupd command fails, it will leave the
systemd service unit in a failed state and systemd will then refuse to
run a unit under the same name with
systemd-runagain until thefailure is cleared.
Thus systematically call
systemctl reset-failedbefore callingsystemd-runto clear any potential failures from previous calls.Do not check the return code of the systemctl command on purpose as it
may fail if the unit does not exists yet, i.e. if no bootupctl command
has been run yet.
Also ignore stdout/stderr to avoid showing unexpected errors messages to
users.
See: #707
See: #663