Add cap-std, use in grubconfigs #674
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting on coreos#449 `openat` is pretty dead upstream, and especially going forward as we start to do more nontrivial file things, it's really useful to have cap-std's additional verification that we aren't accidentally escaping the root. Signed-off-by: Colin Walters <[email protected]>
HuijingHei
reviewed
Jul 1, 2024
| @@ -85,19 +103,23 @@ pub(crate) fn install( | |||
| let vendor = PathBuf::from(vendordir); | |||
| let target = &vendor.join("grub.cfg"); | |||
| let dest_efidir = target_root | |||
| .sub_dir_optional("boot/efi/EFI") | |||
| .open_dir_optional("boot/efi/EFI") | |||
| .context("Opening /boot/efi/EFI")?; | |||
| if let Some(efidir) = dest_efidir { | |||
| efidir | |||
There was a problem hiding this comment.
CI error: error: boot data installation failed: Installing static GRUB configs: Copying static EFI: a path led outside of the filesystem
To copy /usr/lib/bootupd/grub2-static/grub-static-efi.cfg to boot/efi/EFI/fedora/grub.cfg, refer to doc, grub-static-efi.cfg should be relative to self, might use target_root instead of efidir, but not sure if it works as CONFIGDIR is not relative path.
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting on #449
openatis pretty dead upstream, and especially going forward as we start to do more nontrivial file things, it's really useful to have cap-std's additional verification that we aren't accidentally escaping the root.