Update cleaning regex to match RUTs with non-numeric digits #716
+176
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillegas-cdd
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #716 +/- ##
===========================================
+ Coverage 87.60% 87.61% +0.01%
===========================================
Files 38 38
Lines 3130 3134 +4
Branches 385 386 +1
===========================================
+ Hits 2742 2746 +4
Misses 246 246
Partials 142 142 ☔ View full report in Codecov by Sentry. |
svillegas-cdd
force-pushed
the
task/sc-9821-lib-cl-sii-python-rut-cleaning-regex-breaks
branch
5 times, most recently
from
d196489
to
cae80d0
Compare
fpinto-cdd
approved these changes
Oct 2, 2024
jtrobles-cdd
changed the title
|
@svillegas-cdd The link to the file |
jtrobles-cdd
approved these changes
Oct 2, 2024
Yes, it's preferrable not to break URLs into multiple lines. |
svillegas-cdd
force-pushed
the
task/sc-9821-lib-cl-sii-python-rut-cleaning-regex-breaks
branch
2 times, most recently
from
8f5d0c8
to
54303c0
Compare
svillegas-cdd
force-pushed
the
task/sc-9821-lib-cl-sii-python-rut-cleaning-regex-breaks
branch
2 times, most recently
from
2eb9a88
to
421aca7
Compare
|
- The regular expression in `get_subject_rut_from_certificate_pfx` caused the removal of all letters, including the letter K, from the RUTs. - It has been updated to a regex that includes the letter K in certain RUTs. - Added tests for RUTs that end with a `K`. - Added a guide named `howto.md`, which explains how to create a valid `.der` certificate. Based on the guide in `FD-CL-Data` [See](https://github.com/cordada/fd-cl-data/blob/ba85835e81c857acbcc0498751c21335591b17b5/test_data/apps/sii_auth/certificate_pfx/howto.md). Ref: #700 Ref: https://app.shortcut.com/cordada/story/9821
svillegas-cdd
deleted the
task/sc-9821-lib-cl-sii-python-rut-cleaning-regex-breaks
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_subject_rut_from_certificate_pfxcaused the removal of all letters, including the letter K, from the RUTs.K.howto.md, which explains how to create a valid.dercertificate. Based on the guide inFD-CL-DataSee.Ref: #700
Ref: https://app.shortcut.com/cordada/story/9821