[CORL-2887]: update refresh and close button display #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
tessalt
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes update the display of the refresh and close button icons. The updates make it so that the alignment of the icons is more consistent and as we want it to appear.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can test that the refresh and close buttons look as expected locally.
Go to SBN and test that if you update the styles in the same way in dev tools that the alignment of the buttons is as expected. (to make the refresh button show up, navigate to comments, then click to another tab, then back to comments again and see the refresh button)
Where any tests migrated to React Testing Library?
How do we deploy this PR?