Fix TTS().list_models() #3422
Fix TTS().list_models() #3422
Conversation
|
|
|
Hi, just experienced this on the latest update. But I propose we make it a static method or property if possible, because then you wouldn't have to initialize a TTS object just to list the models. That way you don't either have to reinitialize or do load_model_by_name after |
|
Yes, now that the Coqui Studio functionality was removed from that method, it could be made static again. |
TTS/api.py
Outdated
| @@ -122,8 +122,9 @@ def languages(self): | |||
| def get_models_file_path(): | |||
| return Path(__file__).parent / ".models.json" | |||
|
|
|||
| @staticmethod | |||
| def list_models(self): | |||
There was a problem hiding this comment.
| def list_models(self): | |
| def list_models(): |
You also need to sign the CLA for the PR to be merged.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
|
I've merged this into our fork, thank you! |
This currently throws an error because TTS.list_models() returns the ModelManager
Fix by calling list_models() on the model manager
I'm unsure if the functionality of TTS.list_models() was to return the ModelManager object, but this used to return a list of model names and currently does not.