-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load the japanese phonemizer only if there's an environment variable set #2826
Closed
hathibelagal-dev
wants to merge
13
commits into
coqui-ai:dev
from
hathibelagal-dev:fix-mecab-dependency
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6b8b01e
Load the japanese phonemizer only if there's an environment variable set
hathibelagal-dev 20fd267
Enable Japanese during tests
hathibelagal-dev 63dac74
Update __init__.py
hathibelagal-dev 98388cc
Update __init__.py
hathibelagal-dev 42c6949
Fix typo
hathibelagal-dev e5bf79c
Update __init__.py
hathibelagal-dev 4ed2b2d
Merge pull request #1 from hathibelagal-dev/test
hathibelagal-dev 32eee36
Move ENABLE_JAPANESE from global export to individual tests
hathibelagal-dev f19d015
Merge pull request #2 from hathibelagal-dev/fix-mecab-dependency
hathibelagal-dev ad46ef2
Update zoo_tests2.yml
hathibelagal-dev ee03fe5
Update zoo_tests1.yml
hathibelagal-dev a888e65
Update zoo_tests0.yml
hathibelagal-dev 6079a91
Merge pull request #3 from hathibelagal-dev/test
hathibelagal-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,8 @@ jobs: | |
|
||
test: | ||
runs-on: ubuntu-latest | ||
env: | ||
ENABLE_JAPANESE: 1 | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,8 @@ jobs: | |
|
||
test: | ||
runs-on: ubuntu-latest | ||
env: | ||
ENABLE_JAPANESE: 1 | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,8 @@ jobs: | |
|
||
test: | ||
runs-on: ubuntu-latest | ||
env: | ||
ENABLE_JAPANESE: 1 | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can easily try-catch the import and show a warning if the user wants to use JA but it is not installed. ENV variable is not necessary as we already expect you to show your intentions when you install TTS with
pip install TTS[ja]