Make Japanese-specific dependencies optional #2776
Conversation
|
|
|
Thanks for the PR @polm. I think you've forgotten to push the requirements file. Also, do you plan to agree on the CLA? |
|
I added the JA requirements file and agreed to the CLA. |
|
Thanks @polm Tests are failing since JA deps are missing in the testing environment. Probably we should install it all in testing. |
This should help the tests run.
|
JA deps are installed in the test now. A few tests are still failing but they don't seem to have anything to do with Japanese and it's not clear to me why it's happening, so someone more familiar with the test sweet than I am should take a look at it. |
|
@polm thanks I merge and deal with the rest of the CI issues. |
|
When you import TTS it also tries to import the JA dependencies, even if you aren't trying to use the Japanese text to speech. |
* Don't install MeCab by default * Add optional [ja] deps, like [dev] etc * Add JA requirements file * Add JA requirements to requirements_all This should help the tests run.
Hello, I am the maintainer of mecab-python3, unidic-lite, and other Japanese related packages.
Your package uses my packages, but only when dealing with Japanese. My packages are unconditionally required by TTS. However, because my package involves a C++ extension, it is hard to build on M1 Macs. I also do not have the relevant hardware, and so I am unable to distribute wheels for that platform, for details see SamuraiT/mecab-python3#84.
For roughly a year (SamuraiT/mecab-python3#71), people using TTS have intermittently bothered me about how to build things on OSX or other things I am unable to help with. I explained how to fix this in December, but a member of your dev team seemed to consider it low priority, so I took it on myself to make this PR.
This change makes it so Japanese-related dependencies are not installed by default, but can be installed with
tts[ja], similar to the existingtts[dev]. If someone tries to use Japanese and the required packages are missing they will get an ImportError explaining the issue. This change will hopefully make it so people stop asking me for help with my software even though they don't need it in the first place.