Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new shared stops error types #391

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix: new shared stops error types #391

merged 2 commits into from
Aug 11, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Jul 25, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • Code coverage does not significantly worsen (ideally it improves) (remove this if not merging to master)

Description

Unfortunately the superior approach from #390 did not work, and so we must now instead add shared stops errors to gtfs-lib explicitly.

@miles-grant-ibigroup miles-grant-ibigroup mentioned this pull request Aug 8, 2023
Merged
7 tasks
philip-cline
philip-cline approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this is our final approach

@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Aug 11, 2023
@miles-grant-ibigroup miles-grant-ibigroup merged commit 9837b64 into dev Aug 11, 2023
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the shared-stops-validation branch August 11, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br648 br648 br648 approved these changes

@philip-cline philip-cline philip-cline approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @br648 @philip-cline