Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex unit test update #388

Merged
merged 12 commits into from
Aug 10, 2023
Merged

Flex unit test update #388

merged 12 commits into from
Aug 10, 2023

Conversation

br648
Copy link
Collaborator

@br648 br648 commented Jul 11, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

I missed the export of areas from the exported feed. Addressed this and updated the unit tests to cover this.

Added a new unit test to cover normalizing of flex stop times.

binh-dam-ibigroup
binh-dam-ibigroup approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for what the PR describes. See a few code tweaks.

src/main/java/com/conveyal/gtfs/loader/Table.java Outdated Show resolved Hide resolved
src/test/java/com/conveyal/gtfs/GTFSFeedTest.java Show resolved Hide resolved
@br648 br648 assigned philip-cline and unassigned br648 Aug 8, 2023
philip-cline
philip-cline approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

src/test/java/com/conveyal/gtfs/GTFSFeedTest.java Show resolved Hide resolved
@philip-cline philip-cline assigned br648 and unassigned philip-cline Aug 9, 2023
@br648 br648 merged commit 5b4eec6 into dev-flex Aug 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

@philip-cline philip-cline philip-cline approved these changes

Assignees

@br648 br648

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@br648 @binh-dam-ibigroup @philip-cline