-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dependencies): bumping plate packages and react version to 18 [TOL-2415] #1756
Changes from 12 commits
47629b5
9149e1d
98a6c27
065b847
e9ab71a
43b5f7c
bfce04f
cd72f6d
016724b
6d2bd6c
63880ee
4e77ee2
e3d450b
6907ada
27e190c
e995af9
afb311d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ | |
}, | ||
"peerDependencies": { | ||
"@contentful/app-sdk": "^4.29.0", | ||
"react": ">=16.8.0" | ||
"react": ">=17.0.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. here too :D (and in the other ones too :D) |
||
}, | ||
"publishConfig": { | ||
"registry": "https://npm.pkg.github.com/" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,18 +49,18 @@ | |
"@contentful/rich-text-plain-text-renderer": "^16.0.4", | ||
"@contentful/rich-text-types": "16.7.0", | ||
"@popperjs/core": "^2.11.5", | ||
"@udecode/plate-basic-marks": "30.1.2", | ||
"@udecode/plate-break": "30.1.2", | ||
"@udecode/plate-common": "30.1.2", | ||
"@udecode/plate-core": "30.1.2", | ||
"@udecode/plate-list": "30.1.2", | ||
"@udecode/plate-paragraph": "30.1.2", | ||
"@udecode/plate-reset-node": "30.1.2", | ||
"@udecode/plate-select": "30.1.2", | ||
"@udecode/plate-serializer-docx": "30.1.2", | ||
"@udecode/plate-serializer-html": "30.1.2", | ||
"@udecode/plate-table": "30.1.2", | ||
"@udecode/plate-trailing-block": "30.1.2", | ||
"@udecode/plate-basic-marks": "36.0.0", | ||
"@udecode/plate-break": "36.0.0", | ||
"@udecode/plate-common": "36.5.9", | ||
"@udecode/plate-core": "36.5.9", | ||
"@udecode/plate-list": "36.0.0", | ||
"@udecode/plate-paragraph": "36.0.0", | ||
"@udecode/plate-reset-node": "36.0.0", | ||
"@udecode/plate-select": "36.0.0", | ||
"@udecode/plate-serializer-docx": "36.0.10", | ||
"@udecode/plate-serializer-html": "36.0.0", | ||
"@udecode/plate-table": "36.5.9", | ||
"@udecode/plate-trailing-block": "36.0.0", | ||
"constate": "^3.3.2", | ||
"fast-deep-equal": "^3.1.3", | ||
"is-hotkey": "^0.2.0", | ||
|
@@ -72,16 +72,16 @@ | |
"slate-react": "0.102.0" | ||
}, | ||
"peerDependencies": { | ||
"react": ">=16.14.0", | ||
"react-dom": ">=16.14.0" | ||
"react": ">=17.0.2", | ||
"react-dom": ">=17.0.2" | ||
}, | ||
"devDependencies": { | ||
"@contentful/field-editor-test-utils": "^1.5.1", | ||
"@contentful/rich-text-react-renderer": "^15.16.4", | ||
"@types/is-hotkey": "^0.1.6", | ||
"@udecode/plate-test-utils": "^3.2.0", | ||
"prism-react-renderer": "2.4.0", | ||
"react": ">=16.14.0" | ||
"react": "17.0.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dev should be react 18 right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. potentialy we don't even need it as it's in the global package.json? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I think we don't need to change this, but will anyways. Rich text is the only package that even has a react dev dependency |
||
}, | ||
"publishConfig": { | ||
"registry": "https://npm.pkg.github.com/" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a known issue with cypress, if you end a CSV with a comma the cypress command ignores it and runs everything, we are actually running all tests but now in 3 containers instead of splitting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if we have this issue in other projects too? (experience-packages, ..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
experience-packages is not parallelised but yeah it's possible with the combo of test field splitting in circleci