fix: remove lodash-es to fix cjs issues [TOL-1346] #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package:_shared
package:_test
package:boolean
package:checkbox
package:dropdown
package:json
package:list
package:location
package:markdown
package:multiple-line
package:radio
package:rating
package:reference
package:single-line
package:slug
package:tags
package:url
tests
labels
2wce
changed the title
2wce
changed the title
2wce
force-pushed
the
fix/remove-lodash-es-dependency
branch
from
e683681
to
65470b9
Compare
2wce
changed the title
andipaetzold
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@contentful/field-editor-shared is importing lodash-es which seems to cause some issues: https://discord.com/channels/1030176999471321129/1111350294434025613/1132070425254445186
In General:
ESM can import CJS
CJS can't import ESM
@contentful/field-editor-shared is published as CJS and "ESM". Therefore it should only import CJS dependencies. FieldConnector.ts is importing from lodash-es. Also, the package depends on lodash-es. Removing the dependency and avoid importing from lodash-es to have a proper CJS package