Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Add GitHub Issue and PR templates #48

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Conversation

lusu007
Copy link
Member

@lusu007 lusu007 commented Jul 13, 2024

No description provided.

@lusu007 lusu007 self-assigned this Jul 13, 2024
@lusu007 lusu007 requested a review from a team as a code owner July 13, 2024 19:57
@lusu007
Copy link
Member Author

lusu007 commented Jul 13, 2024

I need some input regarding the checklist in the PR template @meyfa. What points should we add?

Copy link
Member

@meyfa meyfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides some minor capitalization changes.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
@meyfa
Copy link
Member

meyfa commented Jul 13, 2024

I need some input regarding the checklist in the PR template @meyfa. What points should we add?

Good question. The PR template is already asking for a proper description and issue reference, so that is out of the way. Depending on the change, we could ask for documentation, and/or tests — but this depends on the PR content, so it might be difficult to turn into an unambiguous rule.

Maybe we can go with just the Conventional Commit one for now and see what comes up in the future and add that.

@lusu007 lusu007 requested a review from meyfa July 14, 2024 10:27
@lusu007 lusu007 merged commit a302ef0 into main Jul 14, 2024
4 checks passed
@lusu007 lusu007 deleted the chore/github-templates branch July 14, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants