Add hf:// as an alias to huggingface:// #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't run tests locally, must keep an extra eye on the builds |
ericcurtin
force-pushed
the
hf-abbrev
branch
2 times, most recently
from
75364ee
to
45fb612
Compare
rhatdan
reviewed
Oct 18, 2024
ramalama/common.py
Outdated
| try: | ||
| return subprocess.run(args, check=True, cwd=cwd, stdout=subprocess.PIPE, stderr=stderr) | ||
| except Exception: | ||
| perror(f"subprocess.run({args}, check=True, cwd={cwd}, stdout=subprocess.PIPE, stderr=stderr)") |
There was a problem hiding this comment.
This line here is for debugging? It is causing tests to fail. The docker error is caught above and ignored.
There was a problem hiding this comment.
I'll remove it, it was for debugging, I was hoping to keep it in, but will remove for now
Also check start of string contains :// , by checking if start of the string simply starts with things like "hf", "ollama", etc. we are kinda polluting the namespace and not allowing models to start with these terms. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
hf-abbrev
branch
2 times, most recently
from
121d56e
to
25335fc
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also check start of string contains :// , by checking if start of the string simply starts with things like "hf", "ollama", etc. we are kinda polluting the namespace and not allowing models to start with these terms.