feat: restart informers from Node empty page #9491
Draft
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Martin <[email protected]>
1 task
benoitf
reviewed
Oct 21, 2024
| </script> | ||
|
|
||
| <EmptyScreen icon={NodeIcon} title="No nodes" message={text} /> | ||
| <EmptyScreen icon={NodeIcon} title="No nodes" message={text}> | ||
| <button onclick={checkContext}>Check connection now</button> |
There was a problem hiding this comment.
I think we don't need the now as the button implies that it would be when we click on it
method being refresh then maybe just Refresh
There was a problem hiding this comment.
also do we need to see the button if there is no context ? as we only do the refresh in case of a context
There was a problem hiding this comment.
This is really to test the backend part, I'm not sure at all if it will be the implementation we want to do in the frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Martin [email protected]
What does this PR do?
Frontend part of #8341
Adds a
Check connection nowto the Nodes list page when the context is not reachable.This is a work in progress, and can be used to test the backend part #9487
Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?