Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add experimental property for toasts #9481

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Oct 21, 2024

What does this PR do?

add property in backend for toasts

Screenshot / video of UI

What issues does this PR fix or reference?

part of #7399

How to test this PR?

  • Tests are covering the bug fix or the new feature

@benoitf benoitf requested a review from a team as a code owner October 21, 2024 07:18
@benoitf benoitf requested review from dgolovin, axel7083 and gastoner and removed request for a team October 21, 2024 07:18
description: 'Display a notification toast when task is created',
type: 'boolean',
default: false,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not hidden ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that 'description: 'Show running tasks in the status bar',' is not hidden as well

so either both of them need to be hidden or all of them need to be visible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah I thought it was hidden, weird

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit ffad59a into containers:main Oct 21, 2024
15 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.14.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants