Make buildah manifest push --all true by default
#5755
Conversation
Changed the `--all` option of `buildah manifest push` to be true by default. This matches the behavior of the equivalent Podman option (`podman manifest push --all`), making it easier to switch between Podman and Buildah. Updated buildah.manifest.push.1 docs to reflect this change. Added test "manifest-push-all-default-true" to `tests/lists.bats`. Closes: containers#5547 Signed-off-by: Paul Nettleton <[email protected]>
|
Could you Fix the man page and add a tests. Test could be the equivalent of: buildah manifest push --help | grep all.*true |
k9withabone
force-pushed
the
manifest-push-all
branch
from
66279f1
to
d081959
Compare
|
Added test "manifest-push-all-default-true" to What's wrong with the man page? |
|
Add information about the default being true. Booleans without default in man pages are assumed False. |
Already done. It is the same as the Podman man page now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, k9withabone The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Changed the
--alloption ofbuildah manifest pushto be true by default. This matches the behavior of the equivalent Podman option (podman manifest push --all), making it easier to switch between Podman and Buildah.Updated buildah-manifest-push(1) docs to reflect this change.
How to verify it
Use
buildah manifest push --help, see that at the end of the line for the--allit says(default true).Which issue(s) this PR fixes:
Fixes #5547
Special notes for your reviewer:
Does this PR introduce a user-facing change?