chroot: add newlines at the end of printed error messages #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we print an error message to stderr, end it with a newline. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
added
the
No New Tests
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
/packit rebuild-failed |
|
/packit rebuild |
mtrmac
reviewed
Sep 30, 2024
| @@ -745,7 +745,7 @@ func runUsingChrootExecMain() { | |||
| logrus.Debugf("Running %#v (PATH = %q)", cmd, os.Getenv("PATH")) | |||
| interrupted := make(chan os.Signal, 100) | |||
| if err = cmd.Start(); err != nil { | |||
| fmt.Fprintf(os.Stderr, "process failed to start with error: %v", err) | |||
| fmt.Fprintf(os.Stderr, "process failed to start with error: %v\n", err) | |||
There was a problem hiding this comment.
This is ~unrelated and pre-existing — the documentation of cmd.Wait() says
The command must have been started by Cmd.Start.
and reading the code ~confirms that .Start must have succeeded. So, shouldn’t this exit immediately?
|
/lgtm |
openshift-merge-bot
bot
merged commit 83b5dcf
into
containers:main
22 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
If we print an error message to stderr, end it with a newline. This should make it easier to tell the difference between multiple error messages.
How to verify it
Manual verification only.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?