-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for COPY --exclude and ADD --exclude options #5733
Conversation
bc97a85
to
ac2e8cc
Compare
@slinkydeveloper PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This needs quite a few more tests to ensure that we're getting this right. Add conformance tests using multiple ways of expressing the sources to be copied (".", "/", "*"), and tests that combine |
One issue is docker does not support --exclude in conformance-test right now. |
Set |
ee82bf0
to
95d1210
Compare
LGTM once comments are addressed and tests are hip |
Is there timeline for landing this? 👀 |
@rhatdan Are there some instructions how to set this up and run the tests? I might try, but please do not count on it 😅 |
dockerfileContents: strings.Join([]string{ | ||
"# syntax=docker/dockerfile:1.9-labs", | ||
"FROM scratch", | ||
"COPY --exclude='!**/*-c' ./ subdir/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Turns out I was mistaken, and quoting does work for the value of the --exclude=
argument.)
Fixes: containers#5678 Signed-off-by: Daniel J Walsh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #5678
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?