debatable improvements #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
force-pushed
the
supakeen-maybe-improvements
branch
from
3ab8f0e
to
a5bd62a
Compare
stefwalter
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Thanks for the contribution. Lots of nice fix ups.
However, I don't think we would capitalize "bootable contaner images" and "image based linux" where ever they appear in the text. Agree we can capitalize in titles though.
Could you also add a Signed-off-by? I'm adding a description of this in #4
supakeen
force-pushed
the
supakeen-maybe-improvements
branch
from
a5bd62a
to
9ccf1e3
Compare
Signed-off-by: Simon de Vlieger <[email protected]>
The sentence has a 'both' in there. Signed-off-by: Simon de Vlieger <[email protected]>
Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
force-pushed
the
supakeen-maybe-improvements
branch
from
9ccf1e3
to
4807343
Compare
Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
force-pushed
the
supakeen-maybe-improvements
branch
from
4807343
to
ff82655
Compare
|
I've backed out the capitalization commit and replaced it with one that only capitalizes in the title :) |
stefwalter
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing these as separate commits as each can probably be discussed/removed from the PR separately. Most of these are likely opinionated as well.