bug: initiator doesn't reconnect when acceptor force closes connection at session endtime #873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an initiator is logged on and the acceptor force closes the connection around session endtime then it looks like the initiator then can't reconnect as it gets in a never ending loop with an
ObjectDisposedException
around the cancellation token of theSocketInitiatorThread
during the call toDisconnect
All this PR does is check if a disconnect has been requested already and if so don't bother with the rest of the disconnect method