Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new package -- altair-aitools-devkit #27849

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

skontar-altair
Copy link

@skontar-altair skontar-altair commented Oct 11, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@skontar-altair
Copy link
Author

I am one of the authors, I would like to get maintainer rights :)

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/altair-aitools-devkit/meta.yaml) and found some lint.

Here's what I've got...

For recipes/altair-aitools-devkit/meta.yaml:

  • The home item is expected in the about section.

For recipes/altair-aitools-devkit/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@pczako-altair
Copy link

Just adding that I'm also one of the authors and confirming my contribution

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/altair-aitools-devkit/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/altair-aitools-devkit/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/altair-aitools-devkit/meta.yaml) and found it was in an excellent condition.

@skontar-altair
Copy link
Author

skontar-altair commented Oct 11, 2024

@conda-forge-admin, please ping conda-forge/help-python team, because the PR is ready for review! :)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

@@ -0,0 +1,55 @@
{% set name = "altair-aitools-devkit" %}
{% set version = "1.0b1" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version: {{ version }}

source:
url: https://maven.rapidminer.com/repository/pypi-snapshot/packages/altair-aitools-devkit/1.0b1/altair_aitools_devkit-1.0b1.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://maven.rapidminer.com/repository/pypi-snapshot/packages/altair-aitools-devkit/1.0b1/altair_aitools_devkit-1.0b1.tar.gz
url: https://maven.rapidminer.com/repository/pypi-snapshot/packages/altair-aitools-devkit/{{ version }}/altair_aitools_devkit-{{ version }}.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants