-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added libstemmer as a package #27842
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Ouch. I took a look at the Makefile and this is not a simple recipe to do your first C(++) package :( |
@xhochy @conda-forge/help-c-cpp First time doing a C package, I think it's a simple one because the build is based on this makefile that's already include in the distro. However win build isn't working, I think because it doesn't recognize the |
@xhochy is this even working for linux and osx? I pretty much just ran the make file |
@xhochy FWIW, here's the content of that makefile:
|
This makefile isn't installing anything. To make this work, you basically need to rewrite it from scratch. |
I guess the makefile is just compiling it and putting them into an archive... |
I'm checking this out and trying to get up to speed... https://conda.org/blog/2023-05-18-how-to-use-conda-build/ |
it looks like the makefile did successfully compiled everything and put it into a |
Eventhough it looks official, it is not the best reference (e.g. please don't use the GCC package). |
@xhochy yeah I caught that will stick with jinja variable for compiler. I'm just not familiar with C myself to know how to make this build a shared library |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).