Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README.md for v1 recipe #27648

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

msarahan
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

We had a developer at NVIDIA try to use the v1 example to submit a recipe:

This had a number of issues. We should try to guide users to avoid the new recipe format until it is completely implemented and tested.

Related to #27646

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Copy link

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/example-v1/README.md:
    • lints:
      • Please put your recipe in its own directory in the recipes/ directory as recipe/<name of feedstock>/<your recipe file>.yaml.

@jakirkham
Copy link
Member

@wolfv could you or someone from your team please review this PR?

A few folks read this example as recommended for consumption, but certain features like uploads were still disabled when they tried. So hopefully this makes it clearer what recommend. Of course we can update this when we are ready to recommend it more broadly, but maybe this should come after/with a blogpost detailing these changes and our recommendations 🙂

@beckermr beckermr merged commit 9544454 into conda-forge:main Oct 11, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants