Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocpsvg #27391

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Add ocpsvg #27391

merged 9 commits into from
Aug 28, 2024

Conversation

ndevenish
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

This package is called cadquery-ocp externally, as it includes
OCP in the python dependency.
Some of the dependencies of this package don't pass pip check themselves
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ocpsvg/meta.yaml) and found some lint.

Here's what I've got...

For recipes/ocpsvg/meta.yaml:

  • The home item is expected in the about section.
  • The summary item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ocpsvg/meta.yaml) and found it was in an excellent condition.

@@ -0,0 +1 @@
mesa-libGLU-devel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really necessary? can you show me the errors without it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is that we've started to remove these from other builds:
conda-forge/qt-main-feedstock#287

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import: 'ocpsvg'
Traceback (most recent call last):
  File "/home/conda/staged-recipes/build_artifacts/ocpsvg_1724522226129/test_tmp/run_test.py", line 2, in <module>
    import ocpsvg
  File "/home/conda/staged-recipes/build_artifacts/ocpsvg_1724522226129/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/ocpsvg/__init__.py", line 1, in <module>
    from .svg import (
  File "/home/conda/staged-recipes/build_artifacts/ocpsvg_1724522226129/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/ocpsvg/svg.py", line 22, in <module>
    from OCP.BRepAdaptor import BRepAdaptor_Curve
ImportError: libGL.so.1: cannot open shared object file: No such file or directory

Copy link
Contributor Author

@ndevenish ndevenish Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gestures towards failed tests]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other mechanism I know about to deal with things like GL are the CDT packages; which I believe is to compile against things that should be present at runtime; but running the tests effectively are runtime, hence needed.

Maybe I only need to add the runtime here; mesa-glu-devel is how I’ve seen it solved before, perhaps I need to be more targeted in just picking up the runtime? I think I was under the impression there was a small allowlist of things that can go here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets see what happens with:

conda-forge/ocp-feedstock#50

This caused the import tests to fail before, but 🤷
@ndevenish
Copy link
Contributor Author

Otherwise, I think this is ready - thank you - shall I ping or will you merge it directly?

@hmaarrfk hmaarrfk merged commit ac7bb60 into conda-forge:main Aug 28, 2024
5 checks passed
@ndevenish ndevenish deleted the ocpsvg branch August 28, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants