-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flite text-to-speech recipe #21976
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/flite:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes, ready for review! |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
@conda-forge/staged-recipes, ready for review! |
Let's close and open this one to toggle the CIs. The logs are long gone here. |
|
||
mkdir -p "${PREFIX}/lib" | ||
|
||
cp -P build/lib/lib*.so.* "${PREFIX}/lib/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use SHLIB_EXT
instead of .so
to catch the macOS .dylib
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check the latest build. It doesn't seem to build shared libs on Mac. There is even an open PR for that: festvox/flite#94 . But again, I'm not very much into maintaining unmerged PRs. So I'd suggest reverting the latest commit and distributing the shared libs only on linux.
macOS is failing with:
You can try a local build to see the right name of this file but I'm guessing that maybe a change from |
recipes/flite/install.sh
Outdated
|
||
mkdir -p "${PREFIX}/lib" | ||
|
||
cp -P build/lib/lib*${SHLIB_EXT}.* "${PREFIX}/lib/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this fixes the macOS build.
cp -P build/lib/lib*${SHLIB_EXT}.* "${PREFIX}/lib/" | |
cp -P build/lib/*${SHLIB_EXT}* "${PREFIX}/lib/" |
This is the list of all files on OS X build:
The package just doesn't build shared libs on OS X. That's what the referenced PR would solve. I can certainly turn it into an issue in the feedstock once it is created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dev packages are skipped for osx because upstream does not support building non-static libs for osx yet. However, the flite binary is still built for osx.
This package is strange because |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).