Add lower bound to numpy compatibility #112
Conversation
conda-forge-admin
requested review from
emmanuelle,
grlee77,
hmaarrfk,
jakirkham,
jni,
msarahan,
ocefpaf,
soupault and
stefanv
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.08.16.12.21.29
|
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
| # https://github.com/conda-forge/numpy-feedstock/issues/324 | ||
| # We must set the lower bound in accordance to scikit-image's | ||
| # runtime requirements | ||
| - numpy >=1.23 |
There was a problem hiding this comment.
No. Otherwise it will overwrite the upper bound too and set the upper bound to be infinite.
There was a problem hiding this comment.
Actually these just become additional lines in depends (including run_exports). So collectively they specify numpy's constraint correctly
Tried to explain this in more detail with an example from scipy where this is already used: conda-forge/numpy-feedstock#324 (comment)
Please let me know in that thread if you have more questions on that
There was a problem hiding this comment.
i guess maybe something changed in how conda/mamba handle repeated dependencies over the years.
It used to be very poorly supported and only one of the lines would get picked up.
There was a problem hiding this comment.
i can remember to try to adjust this later, but i'm almost too scared to try.
xref: xref: conda-forge/numpy-feedstock#324
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #111.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.