Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild with system harfbuzz #102

Merged
merged 5 commits into from
Jan 22, 2023
Merged

Rebuild with system harfbuzz #102

merged 5 commits into from
Jan 22, 2023

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Jan 15, 2023 •
edited by hmaarrfk
Loading

Looking at the build logs from #84 (a faster build) it seems that system harfbuzz is being found and used.

Was there any particular reason to not enable harfbuzz on all platforms for Qt?

Closes #101.

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-webservices conda-forge-webservices bot mentioned this pull request Jan 15, 2023
Closed
3 tasks
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: rerender Rebuild with system harfbuz Jan 15, 2023
@hmaarrfk hmaarrfk marked this pull request as draft January 15, 2023 15:02
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

Looking at the build logs from #84 (a faster build) it seems that system harfbuzz is being found and used.

Was there any particular reason to not enable harfbuzz on all platforms for Qt?

@hmaarrfk hmaarrfk changed the title Rebuild with system harfbuz Rebuild with system harfbuzz Jan 15, 2023
@hmaarrfk hmaarrfk marked this pull request as ready for review January 15, 2023 15:57
@ccordoba12
Copy link
Contributor

Was there any particular reason to not enable harfbuzz on all platforms for Qt?

I don't know if it's really necessary on Mac because it probably has its own font shaping engine. In this regard I'd follow what the Homebrew Qt recipe does.

@hmaarrfk
Copy link
Contributor

Ok i think i understand (sorry this is about the 5th time that you explain to me that OSX does not need harfbuzz)

@hmaarrfk
Copy link
Contributor

Maybe the correct solution is to use system harfbuzz only on linux.

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

(so strange that I can't rerender locally)

@hmaarrfk
Copy link
Contributor

Any final thoughts?

@Tobias-Fischer Tobias-Fischer merged commit f81c1eb into conda-forge:main Jan 22, 2023
@hmaarrfk
Copy link
Contributor

If aarch and pcc64le builds are important, please open an issue and build them in accordance to CFEP03 and I can upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasdiener matthiasdiener matthiasdiener approved these changes

@Tobias-Fischer Tobias-Fischer Tobias-Fischer approved these changes

@andfoy andfoy Awaiting requested review from andfoy andfoy is a code owner

@ccordoba12 ccordoba12 Awaiting requested review from ccordoba12 ccordoba12 is a code owner

@duncanmmacleod duncanmmacleod Awaiting requested review from duncanmmacleod

@gillins gillins Awaiting requested review from gillins gillins is a code owner

@jschueller jschueller Awaiting requested review from jschueller jschueller is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@stuarteberg stuarteberg Awaiting requested review from stuarteberg stuarteberg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qt5 - use system harfbuzz
5 participants
@conda-forge-admin @hmaarrfk @ccordoba12 @matthiasdiener @Tobias-Fischer