Build with CUDA 12.6 #271

jeongseok-meta · 2024-10-04T19:00:07Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-admin · 2024-10-04T19:01:52Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

conda-forge-admin · 2024-10-04T19:06:33Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11185517647.}

jeongseok-meta · 2024-10-04T19:20:03Z

@hmaarrfk I lost from the first step. It seems we can only use CUDA versions listed here, but it doesn't have 12.2.

conda-forge-admin · 2024-10-04T19:26:43Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

The feedstock has no .ci_support files and thus will not build any packages.

conda-forge-admin · 2024-10-04T19:31:11Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11185822661.}

recipe/conda_build_config.yaml

conda-forge-admin · 2024-10-04T20:39:34Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11186641785.}

jeongseok-meta · 2024-10-04T20:40:27Z

@conda-forge-admin, please rerender

hmaarrfk · 2024-10-04T20:44:06Z

recipe/conda_build_config.yaml

+cuda_compiler_version:                              # [linux64]
+  - None                                            # [linux64]
+  - 11.8                                            # [linux64]
+  - 12.0                                            # [linux64]


Suggested change

- 12.0 # [linux64]

- 12.2 # [linux64]

you might need to replicate the rest of everything too.

Rerendering with 12.2 seems to fail per:

If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.

hmaarrfk · 2024-10-04T20:44:21Z

recipe/conda_build_config.yaml

+cuda_compiler_version:                              # [linux64]
+  - None                                            # [linux64]
+  - 11.8                                            # [linux64]
+  - 12.0                                            # [linux64]


you might need to replicate the rest of everything too.

conda-forge-admin · 2024-10-04T20:45:17Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

jeongseok-meta · 2024-10-04T20:51:40Z

@conda-forge-admin, please rerender

hmaarrfk · 2024-10-04T20:58:52Z

👏🏾

hmaarrfk · 2024-10-04T20:59:10Z

"error": "User not authorized for the requested runners, user not present in 'users' list."

set it to azure for now, and see how far you get ;)

hmaarrfk · 2024-10-04T21:04:12Z

You might also want to rebase onto 22bf055

hmaarrfk · 2024-10-04T21:04:33Z

conda-forge.yml

@@ -25,7 +22,4 @@ os_version:
 provider:
  linux_64: github_actions


Suggested change

linux_64: github_actions

linux_64: azure

jeongseok-meta · 2024-10-04T21:16:53Z

@conda-forge-admin, please rerender

jeongseok-meta · 2024-10-04T21:28:42Z

@conda-forge-admin, please restart ci

conda-forge.yml

hmaarrfk · 2024-10-04T22:19:18Z

@conda-forge-admin please rerender

hmaarrfk · 2024-10-04T22:19:29Z

the "yaml" files control the CI files, so you always have to rerender after changing them.

hmaarrfk · 2024-10-04T22:25:25Z

i'm speachless...

conda-forge.yml

…nda-forge-pinning 2024.10.17.15.21.02

jeongseok-meta · 2024-10-18T14:44:10Z

@conda-forge-admin, please rerender

hmaarrfk · 2024-10-18T14:45:33Z

you will only get 360 minutes. no matter what.

As a final test, you can try to compile locally.

If you have a workstation (which i think you must ;) ) then it should take about 1-2 hours with docker

python build-locally.py

hmaarrfk · 2024-10-18T14:46:41Z

However, one question might be whether or not it is worth bumping all the way to 12.6
https://github.com/conda-forge/cupy-feedstock/blob/main/.ci_support/migrations/cuda12x.yaml#L70

hmaarrfk · 2024-10-18T14:48:13Z

recipe/meta.yaml

+#       detect_binary_files_with_prefix: false
+#       run_exports:
+#         - {{ pin_subpackage('pytorch', max_pin='x.x') }}
+#         - {{ pin_subpackage('libtorch', max_pin='x.x') }}


it might be time to undo all these changes and clean up?

jeongseok-meta · 2024-10-18T15:06:59Z

However, one question might be whether or not it is worth bumping all the way to 12.6
https://github.com/conda-forge/cupy-feedstock/blob/main/.ci_support/migrations/cuda12x.yaml#L70

Yeah, I'm down for bumping all the way to 12.6. 12.2 was the minimal required version for our cases, but bumping up to the latest should be fine (let me know if this is not the case though).

jeongseok-meta · 2024-10-18T15:10:02Z

As a final test, you can try to compile locally.

If you have a workstation (which i think you must ;) ) then it should take about 1-2 hours with docker

This sounds good. Let me try. However, how would we proceed when it builds locally (maybe some of the Linux variants but not tested them all) but we don't know whether CI passes or not due to the timeout (and even after merging, how can CI build and upload to the repository)? Sorry, I'm still learning the conda-forge workflow :)

hmaarrfk · 2024-10-18T16:06:37Z

how would we proceed when it builds locally

I can make a small "dummy commit" to your branch and trigger things.

Or eventually, given your tennacity (this is really the requirement), you can become a maintainer here and some more powers get unlocked especially with these runners.

However, they are scarce even for us, so I would have gone through the same process of moving to azure, then building locally.

Co-authored-by: Mark Harfouche <[email protected]>

jeongseok-meta · 2024-10-18T22:32:33Z

@conda-forge-admin, please rerender

conda-forge-admin · 2024-10-18T22:33:51Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

…nda-forge-pinning 2024.10.18.18.09.46

This comment was marked as resolved.

Sign in to view