Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix win-64 tensorflow dependency #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spreka
Copy link
Contributor

@spreka spreka commented Jun 22, 2022

A separate tensorflow dependency is added for win-64 to fix package not found error when installing with conda on Windows.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29, 30]
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

recipe/meta.yaml Outdated
@@ -12,7 +12,7 @@ source:
build:
noarch: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove this line. (noarch: python)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@goanpeca
Copy link
Member

There are ongoing efforts conda-forge/tensorflow-feedstock#111 to have tensorflow builds for windows. But until that happens, the bundle app for napari will not be able to provide plugins for the windows platform that rely on tensorflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants