-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Build with target wasm #82
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.05.17.12.37.09
recipe/build.sh
Outdated
@@ -3,6 +3,8 @@ | |||
set -ex | |||
|
|||
export CXXFLAGS="${CXXFLAGS} -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_AVAILABILITY" | |||
export EMSDK_PATH=${CONDA_EMSDK_DIR} | |||
export WASI_SDK_PATH="" # FIXME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bin/sh: /bin/clang: No such file or directory
make[2]: *** [src/runtime/legacy/CMakeFiles/lfortran_runtime_wasm.dir/build.make:73: src/runtime/legacy/lfortran_runtime_wasm.o] Error 127
make[1]: *** [CMakeFiles/Makefile2:692: src/run
We need the WASI_SDK_PATH
to be set for the above. We use WASI_SDK_PATH/bin/clang
to compile our runtime library src/libasr/runtime/lfortran_intrinsics.c
to WebAssembly Object file which we can later link.
Thanks @IsabelParedes for the PR! Let's document what the blockers are and let's fix them one by one. Is setting Are there other blockers? |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
[ 4%] Cross compiling lfortran_intrinscs.c to lfortran_runtime_wasm.o
../../../../wasi-sdk-22.0/bin/clang: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by ../../../../wasi-sdk-22.0/bin/clang)
make[2]: *** [src/runtime/legacy/CMakeFiles/lfortran_runtime_wasm.dir/build.make:73: src/runtime/legacy/lfortran_runtime_wasm.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:692: src/runtime/legacy/CMakeFiles/lfortran_runtime_wasm.dir/all] Error 2 |
When building locally from the main branch (commit |
You need atleast
|
# To install wasi-sdk | ||
- wget # [unix] | ||
- tar # [unix] | ||
- glib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we pin this to the exact version that is missing?
/lib64/libm.so.6: version `GLIBC_2.27' not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately glib v2.27 is not available. The lowest version on conda-forge is v2.48
recipe/build.sh
Outdated
@@ -2,7 +2,15 @@ | |||
|
|||
set -ex | |||
|
|||
# Install WASI SDK | |||
export WASI_VERSION=22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have tried with WASI SDK
version 19 on my system and version 21 on Ondrej's system. So, maybe let's try/use one of these?
Looks like both |
We made some progress over here #83. I think we are close. Also some observations:
|
We can make a new release of LFortran any time. Just let me know. |
Thanks for the new release!!! |
Closing this in favor of v0.36.0 #84 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)