Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CDT and use conda-forge packages to provide OpenGL on Linux #15

Merged
merged 15 commits into from
Aug 20, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 20, 2024

See:

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits August 20, 2024 06:50
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/irrlicht-feedstock/actions/runs/10466805080.

@traversaro
Copy link
Contributor Author

There was this failure:

[ 38%] Building CXX object CMakeFiles/Irrlicht.dir/source/Irrlicht/CIrrDeviceLinux.cpp.o
$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-c++ -DIRRLICHT_EXPORTS -DIrrlicht_EXPORTS -DNO_IRR_COMPILE_WITH_DIRECT3D_9_ -DNO_IRR_USE_NON_SYSTEM_BZLIB_ -DNO_IRR_USE_NON_SYSTEM_JPEG_LIB_ -DNO_IRR_USE_NON_SYSTEM_LIB_PNG_ -DNO_IRR_USE_NON_SYSTEM_ZLIB_ -I$SRC_DIR/source/Irrlicht -I$SRC_DIR/source/Irrlicht/aesGladman -I$SRC_DIR/source/Irrlicht/lzma -I$SRC_DIR/include -isystem $PREFIX/include/SDL -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/irrlicht-1.8.5 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -fpermissive -O3 -DNDEBUG -fPIC -Wall -pipe -fno-exceptions -fno-strict-aliasing -MD -MT CMakeFiles/Irrlicht.dir/source/Irrlicht/CIrrDeviceLinux.cpp.o -MF CMakeFiles/Irrlicht.dir/source/Irrlicht/CIrrDeviceLinux.cpp.o.d -o CMakeFiles/Irrlicht.dir/source/Irrlicht/CIrrDeviceLinux.cpp.o -c $SRC_DIR/source/Irrlicht/CIrrDeviceLinux.cpp
In file included from /home/conda/feedstock_root/build_artifacts/irrlicht_1724145600341/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/X11/XKBlib.h:31,
                 from /home/conda/feedstock_root/build_artifacts/irrlicht_1724145600341/work/source/Irrlicht/CIrrDeviceLinux.cpp:24:
/home/conda/feedstock_root/build_artifacts/irrlicht_1724145600341/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/X11/extensions/XKBstr.h:405:38: error: expected ';' at end of member declaration
  405 |         char    name[XkbKeyNameLength]  _X_NONSTRING;
      |                                      ^
      |                                        ;
/home/conda/feedstock_root/build_artifacts/irrlicht_1724145600341/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/X11/extensions/XKBstr.h:405:41: error: '_X_NONSTRING' does not name a type
  405 |         char    name[XkbKeyNameLength]  _X_NONSTRING;
      |                                         ^~~~~~~~~~~~
/home/conda/feedstock_root/build_artifacts/irrlicht_1724145600341/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/X11/extensions/XKBstr.h:409:38: error: expected ';' at end of member declaration
  409 |         char    real[XkbKeyNameLength]  _X_NONSTRING;
      |                                      ^
      |                                        ;
/home/conda/feedstock_root/build_artifacts/irrlicht_1724145600341/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/X11/extensions/XKBstr.h:409:41: error: '_X_NONSTRING' does not name a type
  409 |         char    real[XkbKeyNameLength]  _X_NONSTRING;
      |                                         ^~~~~~~~~~~~
/home/conda/feedstock_root/build_artifacts/irrlicht_1724145600341/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/X11/extensions/XKBstr.h:410:39: error: expected ';' at end of member declaration
  410 |         char    alias[XkbKeyNameLength] _X_NONSTRING;
      |                                       ^
      |                                        ;
/home/conda/feedstock_root/build_artifacts/irrlicht_1724145600341/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/X11/extensions/XKBstr.h:410:41: error: '_X_NONSTRING' does not name a type
  410 |         char    alias[XkbKeyNameLength] _X_NONSTRING;
      |                                         ^~~~~~~~~~~~
make[2]: *** [CMakeFiles/Irrlicht.dir/build.make:1308: CMakeFiles/Irrlicht.dir/source/Irrlicht/CIrrDeviceLinux.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '$SRC_DIR/build'
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/Irrlicht.dir/all] Error 2
make[1]: Leaving directory '$SRC_DIR/build'

this was due to installing both xorg-xproto and xorg-xorgproto that actually install the same files. The solution was to install xorg-kbproto instead of xorg-xorgproto, see conda-forge/xorg-xproto-feedstock#14 for the general issue on the problem.

@traversaro traversaro changed the title Drop CDT and use conda-forge packages to provide OpenGL Drop CDT and use conda-forge packages to provide OpenGL on Linux Aug 20, 2024
@traversaro traversaro merged commit c667943 into conda-forge:main Aug 20, 2024
8 checks passed
@traversaro traversaro deleted the removecdt branch August 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant