Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about conda-forge/staged-recipes#6167 #821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jul 22, 2019

@isuruf isuruf requested a review from ocefpaf July 22, 2019 13:22
before starting the process over with the next recipe in the chain.
the builds finish in the dependencies order. Note that due to a bug in that script,
only simple PRs will pass and it is recommended to split the recipes into multiple
PRs in that case.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally 👍 on adding this, though given the suggested flow, it feels a bit out of order. I'd suggest moving this sentence to a warning below and leaving the "Using a single pull request..." sentence in place. Something like this:

.. warning::

    Due to a [bug](https://github.com/conda-forge/staged-recipes/issues/6167) in the script that builds the packages on staged-recipes 
    pull-requests, some complex multi-package pull-requests will fail and, 
    if this happens, it is recommended to split the single pull-request into
    multiple pull-requests

Co-authored-by: Isuru Fernando <[email protected]>
Co-authored-by: Eric Dill <[email protected]>
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 99fc75c
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/65df9a6570725f00073b8651
😎 Deploy Preview https://deploy-preview-821--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaimergp
Copy link
Member

Rebased and updated for Docusaurus assuming that this still happening (referred issue is still open, linked conda issue there was closed as stale, not solved). I added @ericdill's suggestion too.

@jaimergp jaimergp added the Docs label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants