Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions about splitting header and runtime + run_export> packages #2257

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Aug 4, 2024

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

@hmaarrfk hmaarrfk requested a review from a team as a code owner August 4, 2024 15:20
Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit c1eac53
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/66bdf2ff44c2620008ca1423
😎 Deploy Preview https://deploy-preview-2257--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/maintainer/knowledge_base.md Show resolved Hide resolved
docs/maintainer/knowledge_base.md Outdated Show resolved Hide resolved
@jaimergp
Copy link
Member

pre-commit.ci autofix

Comment on lines +1718 to +1737
outputs:
- name: runtime_package_name
# no run_export should be added here. This package is missing the
# development headers and other compilation files.
# Typically this package is suffixed with `-devel`
- name: development_package_name
build:
run_exports:
# the max_pin should be adjusted
- {{ pin_subpackage('runtime_package_name', max_pin='x.x') }}
requirements:
# Add the runtime package as a host dependency to ensure that files are deduplicated between the packages.
host:
- {{ pin_subpackage('runtime_package_name', exact=True) }}
run:
- {{ pin_subpackage('runtime_package_name', exact=True) }}
- other
- required
- compilation
- dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
outputs:
- name: runtime_package_name
# no run_export should be added here. This package is missing the
# development headers and other compilation files.
# Typically this package is suffixed with `-devel`
- name: development_package_name
build:
run_exports:
# the max_pin should be adjusted
- {{ pin_subpackage('runtime_package_name', max_pin='x.x') }}
requirements:
# Add the runtime package as a host dependency to ensure that files are deduplicated between the packages.
host:
- {{ pin_subpackage('runtime_package_name', exact=True) }}
run:
- {{ pin_subpackage('runtime_package_name', exact=True) }}
- other
- required
- compilation
- dependencies
outputs:
- name: libfoo
# no run_export should be added here. This package is missing the
# development headers and other compilation files.
- name: libfoo-devel
build:
run_exports:
# the max_pin should be adjusted
- {{ pin_subpackage('libfoo', max_pin='x.x') }}
requirements:
# Add the runtime package as a host dependency to ensure that files are deduplicated between the packages.
host:
- {{ pin_subpackage('libfoo', exact=True) }}
run:
- {{ pin_subpackage('libfoo', exact=True) }}
- other
- required
- compilation
- dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants