Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra context around required pip flags #2044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhirschfeld
Copy link
Member

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • put any other relevant information below

@dhirschfeld dhirschfeld requested a review from a team as a code owner December 13, 2023 13:36
These options should be used to ensure a clean installation of the package without its
dependencies. This helps make sure that we're only including this package,
and not accidentally bringing any dependencies along into the conda package.
`conda-forge` configures `pip` to ensure a clean installation of the package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually conda build, not conda-forge. A link to what conda-build sets would be useful. I have not been able to find one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In gitter jakirkham linked https://github.com/conda/conda-build/blob/061063f10c51162707c7c5253daa39b2752fcfcc/conda_build/build.py#L3169-L3189

I'll add that reference to the note here. May have to circle back on this though as pre-xmas is getting hectic...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to conda-build now but feel free to add the note too!

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 19a2c0c
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/65dcae31a5fce70008f4a45a
😎 Deploy Preview https://deploy-preview-2044--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dhirschfeld
Copy link
Member Author

Ahhhh, I should circle back and get this over the line!

The link checker seems to be failing with:

✗ [429] https://conda.discourse.group/c/pkg-building/conda-forge/25 | Failed: Network error: Too Many Requests

@jaimergp
Copy link
Member

429s can be ignored. We spammed a bit too much because we had a few PRs running in parallel as I updated the conflicts.

@jaimergp jaimergp added the Docs label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants