Update pinning_deps.rst #1348
Open
Update pinning_deps.rst #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added information about what the pins mean
|
cc @conda-forge/core We'll need to go through this one carefully before merging. |
Improved the contents of some definitions
viniciusdc
reviewed
Apr 10, 2021
src/maintainer/pinning_deps.rst
Outdated
| ABIs and the conda-forge-pinning feedstock | ||
| ========================================== | ||
|
|
||
| conda-forge pinning can be expounded in terms of ABIs (Application Binary Interface), that is, as some programs require specific versions of some API libraries to function correctly - so do some packages require specific versions of some ABIs to function correctly, which is why some libraries used within the conda-forge feedstock are specific to some particular ABI versions. |
There was a problem hiding this comment.
@bashirk Would you mind rewriting this paragraph, I needed to read twice to comprehend.
There was a problem hiding this comment.
Great! I'll work on rewriting this to be as comprehensive as possible.
Many thanks for the feedback.
src/maintainer/pinning_deps.rst
Outdated
|
|
||
| Pins, generally, are all about setting benchmarked versions of packages or libraries that serve as dependencies for some other packages or libraries, just so these dependent packages behave as much as the author(s) of the dependent packages would want them to behave. | ||
|
|
||
| So conda-forge pins are about declaring the standard version (a specific version) of a package dependency that conda-forge or a `conda recipe <https://github.com/conda-forge/staged-recipes>`_ supports, and how recipes that depend on some specific version of some libraries are set in order to not use other varying versions of the dependency. |
There was a problem hiding this comment.
can you add this link https://conda-forge.org/blog/posts/2020-10-02-versions/ has an more outstanding overview of how conda-forge handles the pinning process?
There was a problem hiding this comment.
Awesome! I'll do that.
Many thanks for the input.
Updated contents of the file to include modifications - as directed by reviewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information about what the pins mean
PR Checklist:
make all edits to the docs in the
srcdirectory, not indocsnote any issues closed by this PR with closing keywords
put any other relevant information below
Added documentation on what the pins mean
Related issue: Add docs about what the pins mean #909