Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing numpy lower bounds to scipy #824

Merged
merged 2 commits into from
Aug 17, 2024
Merged

add missing numpy lower bounds to scipy #824

merged 2 commits into from
Aug 17, 2024

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Aug 16, 2024 •
edited
Loading

Noticed by @hmaarrfk in the context of conda-forge/numpy-feedstock#324 - thanks! 🙏

Output of python show_diff.py (excluding some obviously unrelated ffmpeg changes)

>python show_diff.py
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
osx-arm64::scipy-1.13.0-py312h14ffa8f_1.conda
osx-arm64::scipy-1.13.1-py312h14ffa8f_0.conda
osx-arm64::scipy-1.13.0-py311hceeca8c_1.conda
osx-arm64::scipy-1.13.0-py310h7057308_1.conda
osx-arm64::scipy-1.13.0-py39h3d5391c_1.conda
osx-arm64::scipy-1.13.1-py310h7057308_0.conda
osx-arm64::scipy-1.13.1-py39h3d5391c_0.conda
osx-arm64::scipy-1.13.1-py311hceeca8c_0.conda
-    "numpy <2.3",
+    "numpy >=1.22.4,<2.3",
osx-arm64::scipy-1.14.0-py312h14ffa8f_1.conda
osx-arm64::scipy-1.14.0-py310h7057308_2.conda
osx-arm64::scipy-1.14.0-py312h14ffa8f_0.conda
osx-arm64::scipy-1.14.0-py311hceeca8c_1.conda
osx-arm64::scipy-1.14.0-py310h7057308_0.conda
osx-arm64::scipy-1.14.0-py310h7057308_1.conda
osx-arm64::scipy-1.14.0-py311hceeca8c_0.conda
-    "numpy <2.3",
+    "numpy >=1.23.5,<2.3",
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::scipy-1.14.0-py312h9bfcd4c_0.conda
linux-ppc64le::scipy-1.14.0-py311hbefd982_0.conda
linux-ppc64le::scipy-1.14.0-py312h9bfcd4c_1.conda
linux-ppc64le::scipy-1.14.0-py310h784e85a_0.conda
linux-ppc64le::scipy-1.14.0-py311hbefd982_1.conda
linux-ppc64le::scipy-1.14.0-py310h784e85a_1.conda
-    "numpy <2.3",
+    "numpy >=1.23.5,<2.3",
linux-ppc64le::scipy-1.13.1-py310h784e85a_0.conda
linux-ppc64le::scipy-1.13.0-py310h784e85a_1.conda
linux-ppc64le::scipy-1.13.0-py312h9bfcd4c_1.conda
linux-ppc64le::scipy-1.13.1-py39h30478d8_0.conda
linux-ppc64le::scipy-1.13.0-py39h30478d8_1.conda
linux-ppc64le::scipy-1.13.1-py312h9bfcd4c_0.conda
linux-ppc64le::scipy-1.13.0-py311hbefd982_1.conda
linux-ppc64le::scipy-1.13.1-py311hbefd982_0.conda
-    "numpy <2.3",
+    "numpy >=1.22.4,<2.3",
================================================================================
================================================================================
linux-aarch64
linux-aarch64::scipy-1.13.0-py312h37abc14_1.conda
linux-aarch64::scipy-1.13.1-py39hb921187_0.conda
linux-aarch64::scipy-1.13.1-py310h70fbbe5_0.conda
linux-aarch64::scipy-1.13.1-py312h37abc14_0.conda
linux-aarch64::scipy-1.13.0-py39hb921187_1.conda
linux-aarch64::scipy-1.13.1-py311hbd9a39d_0.conda
linux-aarch64::scipy-1.13.0-py310h70fbbe5_1.conda
linux-aarch64::scipy-1.13.0-py311hbd9a39d_1.conda
-    "numpy <2.3",
+    "numpy >=1.22.4,<2.3",
linux-aarch64::scipy-1.14.0-py312h37abc14_1.conda
linux-aarch64::scipy-1.14.0-py311hbd9a39d_1.conda
linux-aarch64::scipy-1.14.0-py310h70fbbe5_1.conda
linux-aarch64::scipy-1.14.0-py312h37abc14_0.conda
linux-aarch64::scipy-1.14.0-py310h70fbbe5_0.conda
linux-aarch64::scipy-1.14.0-py311hbd9a39d_0.conda
-    "numpy <2.3",
+    "numpy >=1.23.5,<2.3",
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
win-64::scipy-1.14.0-py310h46043a1_1.conda
win-64::scipy-1.14.0-py310h46043a1_0.conda
win-64::scipy-1.14.0-py311hd4686c6_0.conda
win-64::scipy-1.14.0-py311hd4686c6_1.conda
win-64::scipy-1.14.0-py312h1f4e10d_1.conda
win-64::scipy-1.14.0-py312h1f4e10d_0.conda
-    "numpy <2.3",
+    "numpy >=1.23.5,<2.3",
win-64::scipy-1.13.0-py310h46043a1_1.conda
win-64::scipy-1.13.1-py311hd4686c6_0.conda
win-64::scipy-1.13.0-py311hd4686c6_1.conda
win-64::scipy-1.13.1-py312h1f4e10d_0.conda
win-64::scipy-1.13.0-py39h1a10956_1.conda
win-64::scipy-1.13.0-py312h1f4e10d_1.conda
win-64::scipy-1.13.1-py39h1a10956_0.conda
win-64::scipy-1.13.1-py310h46043a1_0.conda
-    "numpy <2.3",
+    "numpy >=1.22.4,<2.3",
================================================================================
================================================================================
osx-64
osx-64::scipy-1.14.0-py311h40a1ab3_0.conda
osx-64::scipy-1.14.0-py310h35d8cac_0.conda
osx-64::scipy-1.14.0-py310h35d8cac_1.conda
osx-64::scipy-1.14.0-py312hb9702fa_1.conda
osx-64::scipy-1.14.0-py311h40a1ab3_1.conda
osx-64::scipy-1.14.0-py312hb9702fa_0.conda
-    "numpy <2.3",
+    "numpy >=1.23.5,<2.3",
osx-64::scipy-1.13.0-py311hd5d9b8d_1.conda
osx-64::scipy-1.13.0-py310hca31a43_1.conda
osx-64::scipy-1.13.0-py39h72a3afc_1.conda
osx-64::scipy-1.13.0-py312h741d2f9_1.conda
osx-64::scipy-1.13.1-py311h40a1ab3_0.conda
osx-64::scipy-1.13.1-py39h038d4f4_0.conda
osx-64::scipy-1.13.1-py310h35d8cac_0.conda
osx-64::scipy-1.13.1-py312hb9702fa_0.conda
-    "numpy <2.3",
+    "numpy >=1.22.4,<2.3",
================================================================================
================================================================================
linux-64
linux-64::scipy-1.14.0-py310h93e2701_0.conda
linux-64::scipy-1.14.0-py310h93e2701_1.conda
linux-64::scipy-1.14.0-py312hc2bc53b_0.conda
linux-64::scipy-1.14.0-py312hc2bc53b_1.conda
linux-64::scipy-1.14.0-py311h517d4fd_0.conda
linux-64::scipy-1.14.0-py311h517d4fd_1.conda
-    "numpy <2.3",
+    "numpy >=1.23.5,<2.3",
linux-64::scipy-1.13.0-py39haf93ffa_1.conda
linux-64::scipy-1.13.0-py312hc2bc53b_1.conda
linux-64::scipy-1.13.1-py39haf93ffa_0.conda
linux-64::scipy-1.13.0-py310h93e2701_1.conda
linux-64::scipy-1.13.1-py311h517d4fd_0.conda
linux-64::scipy-1.13.1-py312hc2bc53b_0.conda
linux-64::scipy-1.13.1-py310h93e2701_0.conda
linux-64::scipy-1.13.0-py311h517d4fd_1.conda
-    "numpy <2.3",
+    "numpy >=1.22.4,<2.3",

@h-vetinari h-vetinari requested a review from a team as a code owner August 16, 2024 23:11
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

jakirkham
jakirkham approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Axel! 🙏

Looks good. One question, but not blocking

recipe/patch_yaml/scipy.yaml Outdated Show resolved Hide resolved
@jakirkham jakirkham mentioned this pull request Aug 17, 2024
Closed
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Aug 17, 2024
@github-actions github-actions bot merged commit 6902e54 into conda-forge:main Aug 17, 2024
4 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the numpy branch August 17, 2024 01:56
@h-vetinari h-vetinari mentioned this pull request Aug 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-vetinari @jakirkham