Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender #68

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #67.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #67

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • No valid build backend found for Python recipe for package caiman using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@h-vetinari
Copy link
Member

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/caiman-feedstock/actions/runs/10794024189.

@@ -1,2 +0,0 @@
channel_sources:
- conda-forge,defaults
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we unfortunately need to have both channel sources, at least for now, as on Windows there isn't a remotely-decent tensorflow available in conda-forge. We're working on migrating off tensorflow, but we're not done yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed. The problem is that conda-forge isn't geared to be using any other channel_sources than itself (or at least: doesn't want to be anymore). Getting tensorflow and pytorch built on windows are two long-standing items we want to tackle; pytorch is actually getting close, and hopefully that'll translate to tensorflow soon after.

In any case, depending on the outcome of conda-forge/conda-forge-ci-setup-feedstock#339, you'll probably have to remove windows builds here until we get tensorflow sorted out (and any help for that is welcome!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably removing it from builds that don't need it (meaning other packages) could be done now, with removing it from the allowable configs something that could hold off until it doesn't break anything? We have a lot of users on Windows and losing the ability to package for that platform would be bad for us as a project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
3 participants