Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce General Category blob #124

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Reduce General Category blob #124

merged 8 commits into from
Jun 14, 2024

Conversation

wismill
Copy link
Collaborator

@wismill wismill commented Jun 12, 2024

Reduce General Category blob using the shamochu package. This leads to more than 90% of space savings!

@wismill
Copy link
Collaborator Author

wismill commented Jun 12, 2024

Note: as of now shamochu is not yet released. I will wait a bit for feedback.

EDIT 2024-06-14: it is released

@wismill wismill force-pushed the shamochu branch 4 times, most recently from 660560c to 9f31b6c Compare June 12, 2024 16:10
@wismill wismill marked this pull request as draft June 12, 2024 16:52
@wismill
Copy link
Collaborator Author

wismill commented Jun 12, 2024

Seems to build now. I had to play a bit with the cabal.project file and bump cabal for GHC 9.2. These hacks will not be required once I publish shamochu.

@wismill wismill requested a review from adithyaov June 12, 2024 16:54
This GHC version takes far too much time on the “resolve dependencies”
step. I do not have time to investigate this, but I will deactivate this
GHC version if upgrading cabal does not solve it.
This name is confusing; we are better served with an explicit name.
@wismill wismill marked this pull request as ready for review June 14, 2024 14:55
@wismill
Copy link
Collaborator Author

wismill commented Jun 14, 2024

I will tackle scripts in an alternative to #107.

@wismill
Copy link
Collaborator Author

wismill commented Jun 14, 2024

Would be nice to add ICU tests here. Back to draft

@wismill wismill marked this pull request as draft June 14, 2024 14:58
@wismill wismill mentioned this pull request Jun 14, 2024
@wismill wismill marked this pull request as ready for review June 14, 2024 17:46
@wismill
Copy link
Collaborator Author

wismill commented Jun 14, 2024

ICU test passes locally. shamochu passed the ultimate test 😄

@wismill wismill merged commit a20ed73 into composewell:master Jun 14, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant