Unbox variable length structures #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adithyaov
commented
Jun 27, 2023
adithyaov
commented
Jun 28, 2023
harendra-kumar
requested changes
Jun 28, 2023
| peekByteIndex off arr = do | ||
| len <- Unbox.peekByteIndex off arr :: IO Int | ||
| let off1 = off + Unbox.sizeOf (Proxy :: Proxy Int) | ||
| let peekList buf o 0 = pure (o, reverse buf) |
There was a problem hiding this comment.
In future, for the cases when the order does not matter we can define an alternative instance that does not reverse. That can be done on a newtype wrapper over list.
rnjtranjan
approved these changes
Jul 10, 2023
harendra-kumar
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.