Scientific parser #2410

rnjtranjan · 2023-05-26T09:53:34Z

#2276

streamly.cabal

src/Streamly/Data/Unicode/Parser/Extra.hs

src/Streamly/Internal/Data/Unicode/Parser/Extra.hs

rnjtranjan · 2023-07-06T09:16:33Z

Benchmarks:
#No INLINE
scientific: OK (0.16s)
11.1 ms ± 1.1 ms

#With INLINE
scientific: OK (0.27s)
8.70 ms ± 573 μs

src/Streamly/Internal/Data/Unicode/Parser/Extra.hs

streamly.cabal

test/Streamly/Test/Data/Parser.hs

benchmark/Streamly/Benchmark/Data/Parser.hs

adithyaov · 2023-07-11T09:00:05Z

benchmark/Streamly/Benchmark/Data/Parser.hs

+
+-- | Takes a fold method, and uses it with a default source.
+{-# INLINE benchIOSinkc #-}
+benchIOSinkc


You probably don't need this.

harendra-kumar · 2023-07-24T12:12:35Z

We can keep the tests for scientific and remove the implementation. Use the number parser for tests.

harendra-kumar · 2023-07-25T12:47:14Z

The number parser covers this functionality.

rnjtranjan added this to the 0.9.1 milestone Jun 2, 2023

harendra-kumar requested a review from adithyaov June 21, 2023 10:55

adithyaov force-pushed the scientific_parser branch 3 times, most recently from d1b99c9 to df69a16 Compare June 24, 2023 08:08

rnjtranjan added 4 commits July 6, 2023 08:45

Implement the Scientific parser

d6b31e3

Move Streamly.Data.Unicode.Parser.Extra to the Internal namespace

bd92db1

Add property tests to the scientific parser

d655671

Add benchmarks for the scientific parser

1cd21ad

rnjtranjan force-pushed the scientific_parser branch from df69a16 to 1cd21ad Compare July 6, 2023 03:21

Fix up

1ffb11b

harendra-kumar reviewed Jul 6, 2023

View reviewed changes

streamly.cabal Outdated Show resolved Hide resolved

src/Streamly/Data/Unicode/Parser/Extra.hs Outdated Show resolved Hide resolved

src/Streamly/Internal/Data/Unicode/Parser/Extra.hs Outdated Show resolved Hide resolved

Add Inline

2c14294